From ed6f04daed059ce7f125175909bcf28c4ec8659a Mon Sep 17 00:00:00 2001 From: kawaMANMI Date: Thu, 14 Dec 2023 23:46:28 +0000 Subject: [PATCH 1/3] The 'electron-migration limited' model has been corrected by considering only negative contributions to eta_sei in the j_sei --- pybamm/models/submodels/interface/sei/sei_growth.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pybamm/models/submodels/interface/sei/sei_growth.py b/pybamm/models/submodels/interface/sei/sei_growth.py index 7f6e2771cc..0a75563a79 100644 --- a/pybamm/models/submodels/interface/sei/sei_growth.py +++ b/pybamm/models/submodels/interface/sei/sei_growth.py @@ -134,8 +134,7 @@ def get_coupled_variables(self, variables): elif SEI_option == "electron-migration limited": # Scott Marquis thesis (eq. 5.94) eta_inner = delta_phi - phase_param.U_inner - j_sei = phase_param.kappa_inner * eta_inner / L_sei_inner - + j_sei = phase_param.kappa_inner * eta_inner / L_sei_inner * pybamm.EqualHeaviside(eta_inner, 0) elif SEI_option == "interstitial-diffusion limited": # Scott Marquis thesis (eq. 5.96) j_sei = -( From 066c340f9f31a56d95b89f56f35c199fa648572a Mon Sep 17 00:00:00 2001 From: kawaMANMI <39382602+kawaMANMI@users.noreply.github.com> Date: Fri, 15 Dec 2023 10:21:21 +0000 Subject: [PATCH 2/3] Update pybamm/models/submodels/interface/sei/sei_growth.py Co-authored-by: Eric G. Kratz --- pybamm/models/submodels/interface/sei/sei_growth.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pybamm/models/submodels/interface/sei/sei_growth.py b/pybamm/models/submodels/interface/sei/sei_growth.py index 0a75563a79..b97881241d 100644 --- a/pybamm/models/submodels/interface/sei/sei_growth.py +++ b/pybamm/models/submodels/interface/sei/sei_growth.py @@ -134,7 +134,7 @@ def get_coupled_variables(self, variables): elif SEI_option == "electron-migration limited": # Scott Marquis thesis (eq. 5.94) eta_inner = delta_phi - phase_param.U_inner - j_sei = phase_param.kappa_inner * eta_inner / L_sei_inner * pybamm.EqualHeaviside(eta_inner, 0) + j_sei = pybamm.EqualHeaviside(eta_inner, 0) * phase_param.kappa_inner * eta_inner / L_sei_inner elif SEI_option == "interstitial-diffusion limited": # Scott Marquis thesis (eq. 5.96) j_sei = -( From e05da9dfdffc42ec28079e40642f724e8cefa2a8 Mon Sep 17 00:00:00 2001 From: kawaMANMI Date: Thu, 18 Jan 2024 15:24:12 +0000 Subject: [PATCH 3/3] Logical condition (eta_inner < 0) used instead pybamm.EqualHeaviside for more clarity --- pybamm/models/submodels/interface/sei/sei_growth.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pybamm/models/submodels/interface/sei/sei_growth.py b/pybamm/models/submodels/interface/sei/sei_growth.py index 0a75563a79..89bb662fbc 100644 --- a/pybamm/models/submodels/interface/sei/sei_growth.py +++ b/pybamm/models/submodels/interface/sei/sei_growth.py @@ -134,7 +134,7 @@ def get_coupled_variables(self, variables): elif SEI_option == "electron-migration limited": # Scott Marquis thesis (eq. 5.94) eta_inner = delta_phi - phase_param.U_inner - j_sei = phase_param.kappa_inner * eta_inner / L_sei_inner * pybamm.EqualHeaviside(eta_inner, 0) + j_sei = (eta_inner < 0) * phase_param.kappa_inner * eta_inner / L_sei_inner elif SEI_option == "interstitial-diffusion limited": # Scott Marquis thesis (eq. 5.96) j_sei = -(