From cfcbc1e9fcc3e446af2e938082733ecc7fee27b0 Mon Sep 17 00:00:00 2001 From: John Brittain Date: Thu, 4 May 2023 10:03:06 +0100 Subject: [PATCH 1/3] Remove brew-sundials from the recommended developer installations --- .../installation/install-from-source.rst | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/docs/source/user_guide/installation/install-from-source.rst b/docs/source/user_guide/installation/install-from-source.rst index e3b5e8de85..7a09b2ebe3 100644 --- a/docs/source/user_guide/installation/install-from-source.rst +++ b/docs/source/user_guide/installation/install-from-source.rst @@ -65,9 +65,6 @@ installed on your system. The IDA-based solver is currently unavailable on windows. If you are running windows, you can simply skip this section and jump to :ref:`pybamm-install`. -Using Tox (recommended for GNU/Linux users) -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - .. code:: bash # in the PyBaMM/ directory @@ -76,24 +73,6 @@ Using Tox (recommended for GNU/Linux users) This will download, compile and install the SuiteSparse and SUNDIALS libraries. Both libraries are installed in ``~/.local``. -Using Homebrew (recommended for MacOS users) -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - -If you are using MacOS, an alternative to the above is to get the required SUNDIALS components from Homebrew: - -.. code:: bash - - brew install sundials - -Next, clone the pybind11 and casadi-headers repositories: - -.. code:: bash - - # in the PyBaMM/ directory - git clone https://github.com/pybind/pybind11.git - -That's it. - Manual install of build time requirements ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ From bd697d4da058d111b8c32f71cae48935ec824598 Mon Sep 17 00:00:00 2001 From: John Brittain Date: Thu, 4 May 2023 10:16:19 +0100 Subject: [PATCH 2/3] Add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 25a266d54a..1b0aa11c09 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ ## Bug fixes +- Remove brew install for Mac from the recommended developer installation options for SUNDIALS ([#2925](https://github.com/pybamm-team/PyBaMM/pull/2925)) - Parameter sets can now contain the key "chemistry", and will ignore its value (this previously would give errors in some cases) ([#2901](https://github.com/pybamm-team/PyBaMM/pull/2901)) - Fixed a bug in the discretisation of initial conditions of a scaled variable ([#2856](https://github.com/pybamm-team/PyBaMM/pull/2856)) - Fixed keyerror on "all" when getting sensitivities from IDAKLU solver([#2883](https://github.com/pybamm-team/PyBaMM/pull/2883)) From 4e64f212c024ad76bc3faacad0980f76a34209fd Mon Sep 17 00:00:00 2001 From: Valentin Sulzer Date: Mon, 8 May 2023 14:58:19 -0400 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b0aa11c09..85e98f85d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # [Unreleased](https://github.com/pybamm-team/PyBaMM/) +## Bug fixes + +- Remove brew install for Mac from the recommended developer installation options for SUNDIALS ([#2925](https://github.com/pybamm-team/PyBaMM/pull/2925)) + # [v23.4.1](https://github.com/pybamm-team/PyBaMM/tree/v23.4) - 2023-05-01 ## Bug fixes @@ -21,7 +25,6 @@ ## Bug fixes -- Remove brew install for Mac from the recommended developer installation options for SUNDIALS ([#2925](https://github.com/pybamm-team/PyBaMM/pull/2925)) - Parameter sets can now contain the key "chemistry", and will ignore its value (this previously would give errors in some cases) ([#2901](https://github.com/pybamm-team/PyBaMM/pull/2901)) - Fixed a bug in the discretisation of initial conditions of a scaled variable ([#2856](https://github.com/pybamm-team/PyBaMM/pull/2856)) - Fixed keyerror on "all" when getting sensitivities from IDAKLU solver([#2883](https://github.com/pybamm-team/PyBaMM/pull/2883))