Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings in the JAX BDF integrator #3644

Closed
agriyakhetarpal opened this issue Dec 20, 2023 · 0 comments · Fixed by #3671
Closed

Deprecation warnings in the JAX BDF integrator #3644

agriyakhetarpal opened this issue Dec 20, 2023 · 0 comments · Fixed by #3671
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Dec 20, 2023 •
edited
Loading

At this time, there are two DeprecationWarning(s) associated in the Jax solver which are coming up when running the unit tests:

DeprecationWarning: jax.linear_util.wrap_init is deprecated. Use jax.extend.linear_util.wrap_init instead.

for pybamm\solvers\jax_bdf_solver.py:921 and pybamm\solvers\jax_bdf_solver.py:957. This is marked as an issue with a lower priority than usual because both jax and jaxlib are currently pinned to 0.4.20, but it should be an easy and minimal change since the API does not seem to have changed in this case.
@agriyakhetarpal agriyakhetarpal added difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve labels Dec 20, 2023
@prady0t prady0t mentioned this issue Dec 31, 2023
Merged
8 tasks
@agriyakhetarpal agriyakhetarpal mentioned this issue Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Deprecation warnings of jax_bdf_solver prady0t/PyBaMM
1 participant
@agriyakhetarpal