-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Install from source for M-Series hardware #2897
Comments
I think the error is originating from the fact that the commands =
python {toxinidir}/scripts/install_KLU_Sundials.py
- git clone https://github.com/pybind/pybind11.git {toxinidir}/pybind11 The commands =
tests-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu
tests: python run-tests.py --all
unit: python run-tests.py --unit
integration: python run-tests.py --integration allowing the testing suite to skip the test for [testenv:coverage]
deps =
coverage
scikits.odes
commands =
!windows-!mac: sh -c "pybamm_install_jax"
coverage run run-tests.py --nosub
# Some tests make use of multiple processes through
# multiprocessing. Coverage data is then generated for each
# process separately and data must then be combined into one
# single coverage data file.
coverage combine
coverage xml I am hoping these discrepancies will be solved under GSoC this year :) |
I think executing |
To confirm, this is reproducible on both mac and linux when installing via the brew method. At the moment a quick fix is to specify the following environment variables prior to running
I'm just looking into a cleaner solution... |
Based on #1296 perhaps a way to solve this would be to update the documentation for installing from source, so that the instructions say that:
and
|
Yes, I think directing them to Just note that the Mac install does still rely on I'll update and simplify the install docs in accordance with @agriyakhetarpal suggestion above, specifically point 2. |
PyBaMM Version
Source
Python Version
3.10 & 3.11
Describe the bug
Installing from source results in the following sundials header error via the
brew install sundials
method for M-series hardware. Using,python3 -m tox -e pybamm-requires
fixes the issue. It appears to be a linking issue, as thebrew install sundials
doesn't appear to install libraries in~/.local
. Seems close to #1296Steps to Reproduce
Follow MacOS installation via https://pybamm.readthedocs.io/en/stable/source/user_guide/installation/install-from-source.html#install-from-source-developer-install
Relevant log output
The text was updated successfully, but these errors were encountered: