Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: parameter "Inner SEI reaction proportion" not used in any models #2039

Closed
2 tasks
martinjrobins opened this issue Apr 27, 2022 · 2 comments
Closed
2 tasks
Labels
bug Something isn't working

Comments

@martinjrobins
Copy link
Contributor

PyBaMM Version

develop branch

Python Version

3.8

Describe the bug

The parameter "Inner SEI reaction proportion" appears in:

  • pybamm/input/parameters/lithium_ion/seis/example/parameters.csv
  • pybamm/input/parameters/lithium_ion/seis/ramadass2004/parameters.csv

but is not used anywhere else in pybamm. Perhaps it should be removed?

Steps to Reproduce

n/a

Relevant log output

n/a
@martinjrobins martinjrobins added the bug Something isn't working label Apr 27, 2022
@DrSOKane
Copy link
Contributor

Hi Martin, please keep this parameter. I am currently working on an SEI model that does use it.

@valentinsulzer
Copy link
Member

The degradation parameters are a mess (some duplicate but named differently in different models, some values way off)

@DrSOKane DrSOKane mentioned this issue Jun 15, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants