-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Why pin PyQt to different versions for extra and for CI testing? #241
Comments
Hi @penguinpee, and thanks again for your help in packaging these things for fedora. Honestly, I'm really not sure what's going on with PyQt since yesterday's release of https://pypi.org/project/PyQt6-Qt6/ I feel relatively confident that 0.6.4 didn't contain anything that would suddenly make superqt incompatible, so is it possible that your build is now failing simply because of that upstream problem (which might have gone unnoticed in your builds had v0.6.4 not triggered your tests?) |
i would be curious to see your build failures too. do you have public logs for them? |
it's possible, though I haven't looked into this or verified it yet, that PyQt6-Qt6 started doing a similar lazy-loading thing to what PySide6 was doing that is causing problems with qtpy: spyder-ide/qtpy#480 |
It was not building simply because With the upper bound removed, things build fine downstream. Well, I haven't been able to get the tests working. But that has lower priority on my list, seeing that upstream tests as well. I believe other maintainers are still busy ironing out issues in the Qt6 stack, though. We only have it available fully in rawhide (development). |
Thanks for pointing that out by the way. I'm planning to update Spyder in Fedora, both 5.x and 6.x releases, soon. This might become relevant. Spyder is also what brought superqt on my path. 🧩 |
Yeah, I guess the answer to your question is "because I assumed it was a temporary upstream Qt issue, and because superqt doesn't actually demand the installation of pyqt (making it hard to pin)" |
We don't make PyQt or PySide a runtime requirement either. It's being installed at build time purely for the tests. Whenever possible we want to run tests downstream as well. It's useful since versions in our repository don't always match what upstream has pinned. It gives an idea at least if something is on fire. |
yeah, understood. this is indeed a tricky case i guess. In general, i would say it is absolutely the intention of superqt to be compatible with the latest version of pyqt5 pyside2 pyqt6 and pyside6 (all via qtpy). but that assumes that those packages are themselves installable and importable. I will unpin the test requirements once the upstream issues resolve themselves |
I just had a look at version 0.6.4, which doesn't build in Fedora since we have PyQt6 6.7.0 currently in our development branch. Not a big deal. But I noticed that commit 0ab6758 pins the version for extra
pyqt6
to<6.7
, whereas in.github/workflows/test_and_deploy.yml
it is set toPyQt6<6.6
in the same commit.Why? Shouldn't you be testing with the version that will be installed together with the package?
The text was updated successfully, but these errors were encountered: