Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sklearn 1.1 #621

Closed
kbattocchi opened this issue May 18, 2022 · 1 comment · Fixed by #638
Closed

Support sklearn 1.1 #621

kbattocchi opened this issue May 18, 2022 · 1 comment · Fixed by #638
Assignees

Comments

@kbattocchi
Copy link
Collaborator

Currently, econml is compatible with sklearn 1.0.* but not 1.1 and up; we should fix any incompatibilities.

@kbattocchi kbattocchi self-assigned this May 18, 2022
@riedgar-ms
Copy link

riedgar-ms commented May 31, 2022

An update on this @kbattocchi .... I've put together a sample script which can show the bug:
https://github.com/riedgar-ms/EconML/blob/riedgar-ms/sklearn-stuck/sklearn_issue.py

This works with sklearn 1.0.x, gets stuck with 1.1.0, but appears to work with 1.1.1. So this looks like a bug in SciKit-Learn, but is this something that EconML could monitor and declare failure if some threshold were exceeded?

It might be related to this update in SciKit-Learn:
scikit-learn/scikit-learn@0dfcaee

@kbattocchi kbattocchi linked a pull request Jun 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants