-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More control over table borders #957
Comments
Another interesting suggestion, @tfenne! The current border handling for tables is indeed not particularly flexible, since the available combinations of border lines are essentially hardcoded. As another consequence, they will all have the same color (I haven't checked, but I think Your idea introduces a lot more complexity, but might actually work. As always, the proof is in the PR... 😉 |
Hi @tfenne 😊 Would like to move forward with this suggestion and work on a PR? |
@Lucas-C: someone else (@TedBrookings) on my team is actually actively working on this and will submit a PR hopefully this week. |
FYI, I just posted an update there: #1005 (comment) I apologize for the delay it took for us to answer you 🙏 |
@Lucas-C - I totally understand, and appreciate you circling back now. My teams use of fpdf2 is sporadic, but coincidentally we're just picking up another project where we need to use it, so the timing is actually great. |
Please explain your intent
The Table feature is fantastic, but I find that I want more control over borders that is provided by TableBorderLayout. I would really like to be able to control exactly which borders are turned on, and ideally also their thickness, independently.
Describe the solution you'd like
I was thinking that perhaps:
TableBorderLayout
could become a regular class instead of an enum, so that a user could create instances of itHORIZONTAL_LINES
) could still be class variables so that existing usage doesn't breakFor (3) I'm imagining the function looking something like:
Additional context
I'm actually trying to port some nasty Rmarkdown -> latex -> PDF code, and users have gotten used to some latex table styling, which I can't reproduce. One example is a table with i) thick borders above/below the table, ii) thin borders under the headerline, iii) no other borders.
The text was updated successfully, but these errors were encountered: