Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using updated Sam datase #2018

Closed
apct69 opened this issue Apr 26, 2024 · 4 comments · Fixed by #2020
Closed

Using updated Sam datase #2018

apct69 opened this issue Apr 26, 2024 · 4 comments · Fixed by #2020

Comments

@apct69
Copy link

apct69 commented Apr 26, 2024

Hi, I'm new to using PVlib for master research.
I was wondering what is the best way to use an updated csv file (regarding modules and inverters, for example).
My default installation has a 2019 file.
By downloading the new database from the SAM website.

https://raw.githubusercontent.com/NREL/SAM/develop/deploy/libraries/CEC%20Modules.csv
I wanted to add it this way, but the program continues to use the 2019 file.
sandia_modules = pvlib.pvsystem.retrieve_sam('CECMod','C:\\Users\XXXXX\AppData\Local\Programs\Python\Python312\Lib\site-packages\pvlib\data\CECMod.csv')

By pasting the new database under the name of the old one, I have the new module references.

Do you have any more information on how this function works?
https://pvlib-python.readthedocs.io/en/v0.4.3/generated/pvlib.pvsystem.retrieve_sam.html

Thanks a lot !

@echedey-ls
Copy link
Contributor

Hmm, from looking at the code, when name= is given, it ignores path silently. Just drop the first argument.

That code line should be retrieve_sam(path="https://raw.githubusercontent.com/NREL/SAM/develop/deploy/libraries/CEC%20Modules.csv")

@pvlib/maintainers, I think both the documentation and code need a bit of rework to avoid confusion. In fact, I think this should be a keyword-only function.

@echedey-ls
Copy link
Contributor

Btw @apct69 , you were looking at v0.4.3 documentation (from 2016). We are now at v0.10.4 - there are a few things that have changed since then.

Please follow this link: https://pvlib-python.readthedocs.io/en/stable/

@cwhanse
Copy link
Member

cwhanse commented Apr 26, 2024

@pvlib/maintainers, I think both the documentation and code need a bit of rework to avoid confusion. In fact, I think this should be a keyword-only function.

Agree, I wouldn't have expected what @apct69 reports.

@apct69
Copy link
Author

apct69 commented Apr 26, 2024

Thanks for the fast response, i will be able to choose my favorite panels then :)

I will be looking to the new version of the documentation to learn the use of PVLIB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants