-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account for major pvwatts changes #1350
Comments
Append |
After thumbing up, second thought: append |
The release note itself seems ambiguous, since the "Detailed PV Model" has several module and inverter options, and incomplete, since the parameters for those options aren't identified. Regardless, I think it's a good idea to create and maintain ways in which pvlib users can run a PVWatts version of their choice and to document what that choice implies technically. |
The following note from the SAM website may also be relevant:
|
Is the overall idea to offer a complete set of functions for each (or at least more than one) pvwatts version? |
I think there are two independent goals here. For one, to resolve the ambiguity of what models our current "pvwatts_dc" et al. functions implement. For two, to make space for emulating other PVWatts versions, which yes is something I'd like to do for at least v8. FYI I suspect much of PVWatts v8 is already implemented in pvlib (although called something else, e.g. |
I support those goals. Assuming that there will be several versions implemented eventually (someone might want to add older ones too) then probably there will be only a few base functions that differ from one version to the next. Would the version suffix refer to the version where the function was introduced? Do any of them them predate v5 currently? |
That makes sense to me. The docstring could list any newer versions that also use it.
I don't think any pvlib functions with "pvwatts" in the name (currently just the module, inverter, and system loss models) implement pre-v5 models. My understanding is that versions 1 through 4 used the same performance models (the differences were in other aspects like weather data and UI), so it is sufficient to compare the technical reference for Version 1 with that of Version 5. As an aside, if someone does add the v1 models to pvlib someday, it might be more correct to name them |
The SAM Version 2021.12.02 release notes describe major changes to the PVWatts model:
We should add a note or a warning to
pvsystem.pvwatts_dc
andinverter.pvwatts
. AndModelChain.with_pvwatts
is also now ambiguous.The text was updated successfully, but these errors were encountered: