Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default air temperature and wind speed from ModelChain.run_model etc. #1113

Open
Tracked by #1214
cwhanse opened this issue Dec 15, 2020 · 1 comment
Open
Tracked by #1214
Labels
Milestone

Comments

@cwhanse
Copy link
Member

cwhanse commented Dec 15, 2020

Currently, ModelChain.run_model requires only irradiance as input. Air temperature and wind speed are optional, and if not provided, pvlib defaults to using 20C and 0m/s respectively. ModelChain method docstrings describe this behavior so it is not hidden from the user.

Although convenient for some use cases, supplying default air temperature and wind speed allows ModelChain.run_model() to complete without error if a user has data for e.g. air temperature in the weather input but not in the temp_air column. This behavior is less explicit than desired, IMO.

Similar concerns with ModelChain.run_model_from_poa and ModelChain.run_model_from_effective_irradiance.

Recommended solution: require air temperature and wind speed as inputs for ModelChain.run_model methods, except in the case where cell_temperature is provided as input.

Alternatives: leave as is.

@wholmgren
Copy link
Member

wholmgren commented Feb 4, 2021

We'd need to add some warning/deprecation machinery to address the change in required weather, so it would also be a good opportunity to change the name from temp_air to air_temperature or temperature (#894) or temperature_air (#1012).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants