Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Please, go through these steps before you submit a PR:
Make sure that your PR is not a duplicate.
If not, then make sure that:
a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the
fix/
orfeature/
prefixes. Good examples are:fix/signin-issue
orfeature/issue-templates
.b. You have a descriptive commit message with a short title (first line).
c. You have only one commit (if not, squash them into one commit).
d. Commit message follows convention. Good example is:
Docs: fixes typo in 'rejection' word
.e.
npm test
doesn't throw any error. If it does, fix them first and amend your commit (git commit --amend
).After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.
b. Describe your changes.
c. Put
closes #XXXX
in your comment to auto-close the issue that your PR fixes.Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
IMPORTANT: Please review the CONTRIBUTING section for detailed contributing guidelines.
PLEASE REMOVE THESE NOTES BEFORE SUBMITTING
Fixes #XX
Please provide enough information so that others can review your pull request:
Explain the details for making this change. What existing problem does the pull request solve?
A picture tells a thousand words: