Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/config name #130

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Hotfix/config name #130

merged 2 commits into from
Apr 5, 2024

Conversation

pustovitDmytro
Copy link
Owner

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Please, go through these steps before you submit a PR:

  1. Make sure that your PR is not a duplicate.

  2. If not, then make sure that:

    a. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.

    b. You have a descriptive commit message with a short title (first line).

    c. You have only one commit (if not, squash them into one commit).

    d. Commit message follows convention. Good example is: Docs: fixes typo in 'rejection' word.

    e. npm test doesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).

  3. After these steps, you're ready to open a pull request.

    a. Give a descriptive title to your PR.

    b. Describe your changes.

    c. Put closes #XXXX in your comment to auto-close the issue that your PR fixes.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

IMPORTANT: Please review the CONTRIBUTING section for detailed contributing guidelines.

PLEASE REMOVE THESE NOTES BEFORE SUBMITTING

Fixes #XX

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

A picture tells a thousand words:

@pustovitDmytro pustovitDmytro merged commit e349701 into master Apr 5, 2024
17 of 20 checks passed
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pustovitDmytro added a commit that referenced this pull request Apr 5, 2024
…x for unsupported logger error (#130)

* Fix: config option name not printing as application; Minor grammar fix for unsupported logger error (#128)

* Chore: adds tests to application name configuration

---------

Co-authored-by: Dean Ayalon <deanayalon@me.com>
pustovitDmytro pushed a commit that referenced this pull request Apr 5, 2024
## [1.8.1](v1.8.0...v1.8.1) (2024-04-05)

### Chore

* Update devDependencies (non-major) ([15a82eb](15a82eb))

### Fix

* config option name not printing as application; Minor grammar fix for unsupported logger error (#130) ([4e73cd1](4e73cd1)), closes [#130](#130) [#128](#128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants