-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add login.gov provider #55
Conversation
first stab at login.gov provider
fixing bugs now that I think I understand things better
fixing up dependencies
remove some debug stuff
Fixing all dependencies to point at my fork
…d up []byte stuff, removed client_secret if we are using login.gov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay in getting this reviewed. Between illness, annual leave and doing some research on the login.gov
implementation I have been considering this one for a little while.
I've made a few comments throughout, mostly minor nitpicks but am in general happy with this from a code style perspective.
I have no ability to test this though so I have to rely on you for that. On that note, to accept this change I would really like to add you as the CodeOwner for this provider, meaning future PRs to the code in providers/login_gov.go
would request review from you, is that ok? Can you add the relevant line to the CodeOwners file as a part of this PR?
Co-Authored-By: timothy-spencer <timothy.spencer@gsa.gov>
Co-Authored-By: timothy-spencer <timothy.spencer@gsa.gov>
…ngelog related to PR feedback
Sorry, didn't mean to harass you! Life is indeed busy. :-) I have updated everything that you requested and did a merge with master, updated CODEOWNERS, etc. Let me know what else you need. Thanks! |
By a TODO, did you mean in the code, or an issue in the repo, or something in the README? I would think that an issue would be the best way to do this, but wanted to make sure in case you had something else in mind. :-) |
I would tend to put a |
Hey, anything else you need me to do here? I actually have a few more changes that I am maintaining on another branch that I am using to be able to deploy this stuff in GCP that I'd love to clean up and PR, but it would be hard without all the rest of this stuff. :-) Love to get this merged in! |
@timothy-spencer Thanks for your work on this 😄 |
Thank you for taking the time to review/merge! |
Description
This change does three things:
Motivation and Context
We would like to be able to use the proxy with login.gov.
How Has This Been Tested?
I wrote tests into logingov_test.go, and have been using that.
I also have set up a test application using the login.gov integration environment on my local host,
using the instructions in the README.md.
Checklist: