Add redirect capability to sign_out #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morarucostel
changed the title
JoelSpeed
previously approved these changes
Nov 19, 2019
loshz
previously approved these changes
Nov 19, 2019
JoelSpeed
approved these changes
Nov 19, 2019
|
I fixed up the conflict, going to merge this Thanks @morarucostel for your work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the #311
Description
Added the redirect capability for the
sign_outpath.Motivation and Context
When installed multiple instances of oauth-proxy in the same k8s cluster, for example one instance for app1 and a second one for app2, after the sign_out, the request will get redirected to the same endpoint without the possibility to differenciate among the two paths.
How Has This Been Tested?
Tested in our environments.
Checklist: