Add support for Redis with custom CA. #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loshz
suggested changes
Nov 8, 2019
|
Could you also add an entry to the CHANGELOG please. |
loshz
previously approved these changes
Nov 9, 2019
JoelSpeed
reviewed
Nov 11, 2019
pkg/sessions/redis/redis_store.go
Outdated
| } | ||
|
|
||
| if opts.RedisCAPath != "" { | ||
| rootCAs, _ := x509.SystemCertPool() |
There was a problem hiding this comment.
Why not read the error here? I am generally against ignoring errors from external packages
Co-Authored-By: Joel Speed <Joel.speed@hotmail.co.uk>
JoelSpeed
reviewed
Nov 12, 2019
pkg/apis/options/sessions.go
Outdated
| @@ -27,4 +27,6 @@ type RedisStoreOptions struct { | |||
| UseSentinel bool `flag:"redis-use-sentinel" cfg:"redis_use_sentinel" env:"OAUTH2_PROXY_REDIS_USE_SENTINEL"` | |||
| SentinelMasterName string `flag:"redis-sentinel-master-name" cfg:"redis_sentinel_master_name" env:"OAUTH2_PROXY_REDIS_SENTINEL_MASTER_NAME"` | |||
| SentinelConnectionURLs []string `flag:"redis-sentinel-connection-urls" cfg:"redis_sentinel_connection_urls" env:"OAUTH2_PROXY_REDIS_SENTINEL_CONNECTION_URLS"` | |||
| RedisCAPath string `flag:"redis-ca-path" cfg:"redis_ca_path" env:"OAUTH2_PROXY_REDIS_CA_PATH"` | |||
| RedisInsecureTLS bool `flag:"redis-insecure-tls" cfg:"redis_insecure_tls" env:"OAUTH2_PROXY_REDIS_INSECURE_TLS"` | |||
There was a problem hiding this comment.
I had left a comment here, could I just get an ack that you saw it before I approve this?
There was a problem hiding this comment.
Your comment was about main.go, although you're right that both files should match :). Now it's fixed in here as well.
JoelSpeed
approved these changes
Nov 12, 2019
Jing-ze
pushed a commit
to Jing-ze/oauth2-proxy
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for custom CA for connecting to Redis cache.
Motivation and Context
When running clusters with custom CA for issuing internal certificates redis certificate has to be added to oauth2_proxy, so it can connect to cache.
How Has This Been Tested?
Oauth2_proxy configured to connect to redis configured with custom ca.
Checklist: