Move docker dep commands to earlier in the build #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
reviewed
Jul 15, 2019
dekimsey
force-pushed
the
improve-docker-rebuild-caching
branch
from
ec71678 to
c82dbd1
Compare
JoelSpeed
previously approved these changes
Jul 15, 2019
This will let Docker cache the results of the vendor dependencies. Making re-builds during testing faster. Also clean-up spurious test & rm in ./configure
dekimsey
force-pushed
the
improve-docker-rebuild-caching
branch
from
c82dbd1 to
816c2a6
Compare
JoelSpeed
approved these changes
Jul 15, 2019
|
I squashed all the changes. Feel free to merge when ready. |
Jing-ze
pushed a commit
to Jing-ze/oauth2-proxy
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will let Docker cache the results of the vendor dependencies.
Making re-builds during testing faster.
I also changed the logic to just
rm -fthe .env which silences a spurious error message I was encountering.Motivation and Context
To test my changes, I'm just running
docker build .repeatedly. I found the dep ensure command took a long time to do it's work.How Has This Been Tested?
It builds without triggering re-downloading of vendor artifacts.
Checklist: