Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch linter to golangci-lint #198

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Switch linter to golangci-lint #198

merged 4 commits into from
Jul 1, 2019

Conversation

steakunderscore
Copy link
Contributor

@steakunderscore steakunderscore commented Jun 23, 2019 •
edited
Loading

Description

Fixes #194. Replace the depricated linter with golangci-lint.

Motivation and Context

How Has This Been Tested?

  • - Run make test
  • - Run make lint
  • - Run make docker

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@steakunderscore steakunderscore requested a review from a team June 23, 2019 19:54
@steakunderscore steakunderscore force-pushed the switch_to_golangci-lint branch from c89b77c to 5bcb998 Compare June 23, 2019 20:39
JoelSpeed
JoelSpeed reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question, if you could verify what I've said below then I'm happy to get this merged

.golangci.yml Outdated Show resolved Hide resolved
JoelSpeed
JoelSpeed approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JoelSpeed JoelSpeed merged commit 85c5cef into oauth2-proxy:master Jul 1, 2019
@steakunderscore steakunderscore mentioned this pull request Jul 1, 2019
Closed
3 tasks
@steakunderscore steakunderscore deleted the switch_to_golangci-lint branch July 1, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace gometalinter which is deprecated
2 participants
@steakunderscore @JoelSpeed