-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds banner flag #195
Merged
Merged
Adds banner flag #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoposse
previously approved these changes
Jun 20, 2019
This is to override what's displayed on the main page.
ed02c21
to
b9cfa8f
Compare
tiagoposse
previously approved these changes
Jun 27, 2019
Do we know when a release with this is coming? This would be really handy! |
@JoelSpeed are you able to help with this? |
JoelSpeed
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will be cutting a release next week hopefully
That is great! Thank you! |
Thanks @JoelSpeed ! |
T-vK
pushed a commit
to T-vK/oauth2-proxy
that referenced
this pull request
Nov 20, 2024
…upgrade Updated the Redis chart to the latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a banner flag to override what's displayed on the main login page.
Motivation and Context
This is to implement the suggestion in #193
How Has This Been Tested?
Built docker image after applying patch in #190. Run in Kubernetes to load page and see that both
-banner='-'
and-banner='My sweet banner'
worked.Checklist: