Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds banner flag #195

Merged
merged 3 commits into from
Jul 4, 2019
Merged

Conversation

steakunderscore
Copy link
Contributor

@steakunderscore steakunderscore commented Jun 19, 2019

Description

Adds a banner flag to override what's displayed on the main login page.

Motivation and Context

This is to implement the suggestion in #193

How Has This Been Tested?

Built docker image after applying patch in #190. Run in Kubernetes to load page and see that both -banner='-' and -banner='My sweet banner' worked.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@steakunderscore steakunderscore requested a review from a team June 19, 2019 14:34
tiagoposse
tiagoposse previously approved these changes Jun 20, 2019
Henry Jenkins added 2 commits June 25, 2019 16:41
This is to override what's displayed on the main page.
tiagoposse
tiagoposse previously approved these changes Jun 27, 2019
@RichardoC
Copy link

Do we know when a release with this is coming? This would be really handy!

@dcomas
Copy link

dcomas commented Jul 4, 2019

@JoelSpeed are you able to help with this?

Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will be cutting a release next week hopefully

@JoelSpeed JoelSpeed merged commit 4eefc01 into oauth2-proxy:master Jul 4, 2019
@steakunderscore steakunderscore deleted the banner-flag branch July 4, 2019 10:25
@dcomas
Copy link

dcomas commented Jul 4, 2019

LGTM, will be cutting a release next week hopefully

That is great! Thank you!

@steakunderscore
Copy link
Contributor Author

Thanks @JoelSpeed !

@eritikass eritikass mentioned this pull request Mar 26, 2020
3 tasks
T-vK pushed a commit to T-vK/oauth2-proxy that referenced this pull request Nov 20, 2024
…upgrade

 Updated the Redis chart to the latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants