Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-oidc #175

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Bump go-oidc #175

merged 2 commits into from
Jun 6, 2019

Conversation

aeijdenberg
Copy link
Contributor

@aeijdenberg aeijdenberg commented Jun 3, 2019

Description

Latest go-oidc contains coreos/go-oidc@20c0c22 which ensures that the SupportedSigningAlgs is never empty.

Motivation and Context

If -skip-oidc-discovery / OAUTH2_SKIP_OIDC_DISCOVERY / skip_oidc_discovery is set, then this codepath will create a verifier with no signature algorithms set. With previous versions of go-oidc, that would skip checking if the alg is in a whitelist, which may allow the infamous none algorithm be evaluated.

How Has This Been Tested?

I haven't tried to exploit this, it just stood out while reviewing this code for common errors - and given that generally during an authorization_code flow the token is fetched directly from the IdP, rather than accepted from users via a header (and due to other reasons listed in the go-oidc commit), it may not easily be exploitable, but still should be fixed, since it's easy.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@aeijdenberg aeijdenberg requested a review from a team June 3, 2019 05:08
@JoelSpeed
Copy link
Member

JoelSpeed commented Jun 3, 2019

Hey, good spot, seems like a reasonable change

Since this fix is in the v2.0.0 release, perhaps it would be better to add an override to the Gopkg.toml and then pin to a release? WDYT?

Could you add a CHANGELOG entry to include the updated version, I feel this is important enough to note in the changelog

Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoelSpeed JoelSpeed merged commit 572646e into oauth2-proxy:master Jun 6, 2019
@aeijdenberg aeijdenberg deleted the bumpoidc branch June 7, 2019 03:22
T-vK pushed a commit to T-vK/oauth2-proxy that referenced this pull request Nov 20, 2024
…erviceaccountnamespace

Fix Role & Rolebinding namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants