-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create option to skip verified email check in OIDC provider #159
Create option to skip verified email check in OIDC provider #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick fix then this LGTM, thank!
4fe18a2
to
be6d5c8
Compare
Is this good to merge? |
Will this feature be merged ? (blocking issue to use OIDC provider like UAA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one final thought having looked at this, how do you feel about renaming the flag to be prefixed with insecure
to let people know this is an insecure option, I'm thinking like insecure-skip-tls-verify
for isntance?
Also, please add a note to the Changelog before we merge
3e62474
to
776d063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
My oidc provider return email_verified claim as string instead of boolean. This is causing an unmarshalling issue during callback handling. Is there a way to get rid off it. I tried using "allow-unverified-emails" but that didn't work. |
@iamfarsk were you able to make this work? |
I switched the oidc provider. Probably you can try the latest version if
not tried yet.
…On Fri, Feb 19, 2021 at 5:44 PM Muhammad Hamza Zaib < ***@***.***> wrote:
@iamfarsk
<https://github.com/iamfarsk>
were you able to make this work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGI2S3SGD36HPMKKK6VD2STS7ZI2VANCNFSM4HODP43Q>
.
--
Farhan
Disclaimer
The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.
|
I had skipped the |
…text_improvements Improved securityContext and timeout of the initContainer wait-for-redis
Motivation and Context
Some OIDC identity providers don't verify email addresses but still set the "email_verified" claim to false, which results in a 500 error from oauth2_proxy. This option allows the "email_verified" check to be skipped.
Fixes #117
How Has This Been Tested?
Tested manually using the docker container with Auth0 as an OIDC provider:
Checklist: