-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose -cookie-path as configuration parameter #122
Expose -cookie-path as configuration parameter #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a sensible improvement. Thanks 😄
Just one little thing before this gets merged, could you update the documentation to add this flag to the list of flags? |
Good catch, thank you for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 🎉
* Checksum for alphaConfig This patch adds a checksum to the deployment to trigger a restart of the pods, if the config-alpha changes. Pretty similar to the remaining checksums. Signed-off-by: Sven Haardiek <sven.haardiek@uni-muenster.de> * Fix version (new version merged before review) Signed-off-by: Sven Haardiek <sven.haardiek@uni-muenster.de> Co-authored-by: Cédric de Saint Martin <cdesaintmartin@wiremind.io>
Description
Exposes the Path attribute of the cookie as config parameter
-cookie-path
to allow be more flexible cookie configuration.Motivation and Context
This is the PR for the issue #121
How Has This Been Tested?
Unit tests are passing.
Tested in our environments.
Checklist: