Encrypting user/email from cookie #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoelSpeed, Just pushed the code for encrypting the user and email for the new json encoding of the cookie. |
JoelSpeed
reviewed
Apr 10, 2019
providers/session_state.go
Outdated
| @@ -62,6 +62,19 @@ func (s *SessionState) EncodeSessionState(c *cookie.Cipher) (string, error) { | |||
| } else { | |||
| ss = *s | |||
| var err error | |||
| // Encrypt also Email and User when cipher is provided | |||
There was a problem hiding this comment.
I'm not sure this comment is necessary, personally I would drop it but happy to leave if you feel strongly about it
There was a problem hiding this comment.
Yes, I guess from this point forward there is no different treatment in encrypting the email and user versus the other fields. Removing the comment.
JoelSpeed
approved these changes
Apr 10, 2019
T-vK
pushed a commit
to T-vK/oauth2-proxy
that referenced
this pull request
Nov 20, 2024
Correct label in NOTES.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change does one thing:
if a cypher is provided, it encrypts also the email and user with the same logic and algorithm as the rest of the fields from the session state.
Motivation and Context
This is the PR for the issue #60 .
Don't expose any information part of the cookie, information that can be easily retrieved if not encrypted.
How Has This Been Tested?
All the test from session_state_test are passing.
Testing in our environments.
Checklist: