Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using it with Apache Zeppelin (it requires websocket), it got 500 error with "WebSocket handshake: Unexpected response code: 500".
With some investigation, it's caused by lack support of
http.Hijacker
, it raised 500 error from here.This PR added
http.Hijacker
support toresponseLogger
to resolve above issue.There is one more nice to have change, which is to support value case insensitive for header
Connection
because nginx documented to useproxy_set_header Connection "upgrade"
from here. The current implementation only acceptUpgrade
.Motivation and Context
go version: v1.12
Using it with Apache Zeppelin, it got 500 error with "WebSocket handshake: Unexpected response code: 500".
How Has This Been Tested?
Checklist: