Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Code Push with EsLint Plugin #262

Merged
merged 22 commits into from
Mar 11, 2024
Merged

Conversation

ChristopherPHolder
Copy link
Collaborator

No description provided.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Also the CI passes!

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad you could make it work! 🎉

The Code PushUp CLI works both locally and in the pipelines. In the portal, I see the results correctly.

It seems that both production and test code are linted correctly from multiple packages (I see issues from multiple packages, including Jest rules).

I added a comment regarding the configuration, ping me if needed!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

☕ Order Coffee ☕

Date/Time: 2024-03-11 08:40

Step Name Gather Mode Performance Accessibility Best Practices Seo Pwa
🧭 Navigate to coffee cart navigation 🔒 96 97 100 85 30
☕ Select coffee timespan 11/11 - 7/7 - -
✔ Coffee selected snapshot Ø 3/3 15/16 5/5 7/9 -
🛒 Checkout order timespan 13/13 - 7/7 - -
🧾 Order checked out snapshot Ø 3/3 17/18 5/5 7/9 -
💌 Submit order timespan 13/13 - 7/7 - -
📧 Order submitted snapshot Ø 3/3 15/16 5/5 7/9 -
🧭 Navigate to github navigation 🔒 99 96 100 85 30
🔒 Budgets

🧭 Navigate to coffee cart

Resource Size Budget

Resource Type Transfer Size Over Budget
Script 162.15 KB 162.15 KB
Stylesheet 3.65 KB 3.65 KB
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1.19 KB -
Other 713 Bytes -
Third-party 94.9 KB -

Resource Count Budget

Resource Type Requests Over Budget
Script 2 1 request
Stylesheet 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 2 2 requests
Third-party 3 3 requests

Timing Budget

Metric Measurement Over Budget
Largest Contentful Paint 2378 ms 2368 ms
First Contentful Paint 1686 ms 1676 ms
Speed Index 1686 ms 1676 ms
Total Blocking Time 136 ms 126 ms
Cumulative Layout Shift 0.00 -

🧭 Navigate to github

Resource Size Budget

Resource Type Transfer Size Over Budget
Script 41 Bytes 41 Bytes
Stylesheet 40 Bytes 40 Bytes
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1016 Bytes -
Other 0 Bytes -
Third-party 0 Bytes -

Resource Count Budget

Resource Type Requests Over Budget
Script 2 1 request
Stylesheet 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 1 1 request
Third-party 3 3 requests

Timing Budget

Metric Measurement Over Budget
Largest Contentful Paint 1538 ms 1528 ms
First Contentful Paint 858 ms 848 ms
Speed Index 858 ms 848 ms
Total Blocking Time 103 ms 93 ms
Cumulative Layout Shift 0.00 -

Copy link

❗❗❗ report generated by this PR ❗❗❗

☕ Order Coffee ☕

Date/Time: 2024-03-11 08:40

Step Name Gather Mode Performance Accessibility Best Practices Seo Pwa
🧭 Navigate to coffee cart navigation 🔒 91 97 100 85 30
☕ Select coffee timespan 11/11 - 7/7 - -
✔ Coffee selected snapshot Ø 3/3 15/16 5/5 7/9 -
🛒 Checkout order timespan 13/13 - 7/7 - -
🧾 Order checked out snapshot Ø 3/3 17/18 5/5 7/9 -
💌 Submit order timespan 13/13 - 7/7 - -
📧 Order submitted snapshot Ø 3/3 15/16 5/5 7/9 -
🧭 Navigate to github navigation 🔒 99 96 100 85 30
🔒 Budgets

🧭 Navigate to coffee cart

Resource Size Budget

Resource Type Transfer Size Over Budget
Script 162.15 KB 162.15 KB
Stylesheet 3.64 KB 3.64 KB
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1.19 KB -
Other 687 Bytes -
Third-party 94.98 KB -

Resource Count Budget

Resource Type Requests Over Budget
Script 2 1 request
Stylesheet 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 2 2 requests
Third-party 3 3 requests

Timing Budget

Metric Measurement Over Budget
Largest Contentful Paint 3060 ms 3050 ms
First Contentful Paint 1680 ms 1670 ms
Speed Index 1680 ms 1670 ms
Total Blocking Time 150 ms 140 ms
Cumulative Layout Shift 0.00 -

🧭 Navigate to github

Resource Size Budget

Resource Type Transfer Size Over Budget
Stylesheet 41 Bytes 41 Bytes
Script 41 Bytes 41 Bytes
Image 0 Bytes -
Media 0 Bytes -
Font 0 Bytes -
Document 1016 Bytes -
Other 0 Bytes -
Third-party 0 Bytes -

Resource Count Budget

Resource Type Requests Over Budget
Stylesheet 2 1 request
Script 2 1 request
Image 0 -
Media 0 -
Font 0 -
Document 1 -
Other 1 1 request
Third-party 3 3 requests

Timing Budget

Metric Measurement Over Budget
Largest Contentful Paint 1533 ms 1523 ms
First Contentful Paint 857 ms 847 ms
Speed Index 857 ms 847 ms
Total Blocking Time 104 ms 94 ms
Cumulative Layout Shift 0.00 -

@ChristopherPHolder ChristopherPHolder merged commit 8f03326 into main Mar 11, 2024
3 checks passed
@ChristopherPHolder ChristopherPHolder deleted the chore/setup-code-pushup branch March 11, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants