Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frequency uses NonEmptyList, oneOf uses NonEmptyArray #128

Closed
drathier opened this issue Feb 4, 2022 · 1 comment · Fixed by #131
Closed

frequency uses NonEmptyList, oneOf uses NonEmptyArray #128

drathier opened this issue Feb 4, 2022 · 1 comment · Fixed by #131
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Comments

@drathier
Copy link

drathier commented Feb 4, 2022

It's a real road-bump that these two don't accept the same type. Switching from oneOf to frequency shouldn't require me to add a new import and use a different list type.

https://github.com/purescript/purescript-quickcheck/blob/v7.1.0/src/Test/QuickCheck/Gen.purs#L158-L166
@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Feb 4, 2022
@JordanMartinez
Copy link
Contributor

I'm adding this as a breaking change.

@JordanMartinez JordanMartinez mentioned this issue Feb 15, 2022
Closed
4 tasks
@JordanMartinez JordanMartinez mentioned this issue Mar 16, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NonEmptyArray rather than NEL for frequency
Change frequency type sig to take NonEmptyArray
2 participants
@drathier @JordanMartinez