Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove createFactory? #142

Closed
safareli opened this issue Apr 13, 2018 · 3 comments
Closed

Remove createFactory? #142

safareli opened this issue Apr 13, 2018 · 3 comments

Comments

@safareli
Copy link
Contributor

Is there a point of having createFactory? it just call's createElement

https://github.com/facebook/react/blob/master/packages/react/src/ReactElement.js#L260-L273
@safareli
Copy link
Contributor Author

based on current definition of createFactory in react, we can define it here as:
createFactory cls props = createElement cls props mempty

and as it has no advantages we can just remove it.

@paulyoung
Copy link
Contributor

This came up in #128, and I thought it was removed in #129.

@safareli
Copy link
Contributor Author

safareli commented Apr 13, 2018 •
edited
Loading

Ah I was looking at old version of this lib :d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulyoung @safareli