Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close in vsphere_helper throws an error if a connection was never made #211

Closed
glennsarti opened this issue Mar 17, 2017 · 1 comment
Closed

close in vsphere_helper throws an error if a connection was never made #211

glennsarti opened this issue Mar 17, 2017 · 1 comment

Comments

@glennsarti
Copy link
Contributor

The close method does not properly guard against the @connection object being in an un-closable state. This should be updated to check the state of the object prior to trying to close it.

https://github.com/puppetlabs/vmpooler/blob/master/lib/vmpooler/vsphere_helper.rb#L412-L414
@mattkirby
Copy link
Contributor

It looks like this has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattkirby @glennsarti