Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback URL for OAuth2 provider redirect #7

Closed
binlab opened this issue Mar 25, 2020 · 4 comments
Closed

Callback URL for OAuth2 provider redirect #7

binlab opened this issue Mar 25, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@binlab
Copy link

binlab commented Mar 25, 2020

Use Case

Would be nice to add endpoint URL on Vault side to automatically forward the user to Vault and skip a step - vault write oauth2/bitbucket/creds/my-user-auth

Describe the Solution You Would Like

Callback URL e.g. http://127.0.0.1:8200/oauth2/bitbucket/callback
similar to how implemented here https://www.vaultproject.io/api-docs/auth/jwt/#oidc-callback

Describe Alternatives You've Considered


Additional Context


@binlab binlab added the enhancement New feature or request label Mar 25, 2020
@impl
Copy link
Member

impl commented Mar 25, 2020

This seems related to #6 (review). Is the goal here to implement a single point for both external use and authentication to Vault?

@impl impl self-assigned this Mar 25, 2020
@binlab
Copy link
Author

binlab commented May 7, 2020

Thanks for reply @impl! Rather it can simplify the setup and don't need manual work to transfer the code and just press button to approve

@DrDaveD
Copy link
Contributor

DrDaveD commented Sep 18, 2020

@binlab Note that the vault-plugin-auth-jwt api you listed isn't actually for the token issuer to call back directly to vault; the token issuer has to call back to an extra little web server started by the vault cli, and then the vault cli calls back to the vault server.

Maybe what you're wanting is in this vault-plugin-auth-jwt pull request, combined with the #6 feature here.

@impl
Copy link
Member

impl commented Sep 15, 2021

Hello!

I've spent a while (well, a year now) noodling on this and I think it would expand the scope of the plugin beyond what's reasonably feasible for us to implement and maintain (e.g., requiring handling browser requests and defining client-side interaction like redirects). If someone from the community wanted to propose this functionality in a PR, we would certainly consider it, but I don't think this is a candidate for us to develop at this time.

Thanks for the suggestion!

@impl impl closed this as completed Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants