Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RE-13304) add apt-transport-https to debian #1631

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

mihaibuzgau
Copy link
Contributor

@mihaibuzgau mihaibuzgau commented Mar 11, 2020

the puppet-release package is now setting the url for apt puppet-agent repo to https transport. On the default Debian installation < 10 apt-transport-https is not provided causing the installation of puppet-agent to fail.
This PR adds apt-transport-https to the provisioning phase of beaker.

@mihaibuzgau mihaibuzgau requested a review from a team as a code owner March 11, 2020 08:13
@mihaibuzgau
Copy link
Contributor Author

mihaibuzgau commented Mar 11, 2020

beaker provision on debian-8:

[redacted] (debian8-64-1) 11:28:20$ dpkg -s apt-transport-https
  Package: apt-transport-https
  Status: install ok installed
  Priority: optional
  Section: admin
  Installed-Size: 190

Debian 9:

[redacted](debian9-64-1) 11:36:31$ apt-get install --force-yes  -y apt-transport-https
  Reading package lists...
  Building dependency tree...
  Reading state information...
  The following NEW packages will be installed:
    apt-transport-https
  0 upgraded, 1 newly installed, 0 to remove and 176 not upgraded.
  Need to get 171 kB of archives.

Debian 10:

[redacted] (debian10-64-1) 11:42:08$ apt-get install --force-yes  -y apt-transport-https
  Reading package lists...
  Building dependency tree...
  Reading state information...
  The following NEW packages will be installed:
    apt-transport-https
  0 upgraded, 1 newly installed, 0 to remove and 84 not upgraded.

Ubuntu 14.04 - already installed

root@[redacted]:~# apt list --installed | grep apt-transport-https

WARNING: apt does not have a stable CLI interface yet. Use with caution in scripts.

apt-transport-https/now 1.0.1ubuntu2.6 amd64 [installed,upgradable to: 1.0.1ubuntu2.18]

Ubuntu 16.04 - already installed

root@[redacted]:~# apt list --installed | grep apt-transport-https

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

apt-transport-https/xenial-updates,now 1.2.27 amd64 [installed]

Ubuntu 18.04 - not installed and not needed, since it knows how to handle https repos.

@Magisus
Copy link
Contributor

Magisus commented Mar 11, 2020

This is blocking puppetserver's pipelines too, when installing PuppetDB, from this function https://github.com/puppetlabs/beaker-puppet/blob/master/lib/beaker-puppet/install_utils/foss_utils.rb#L1062-L1064. However, I wasn't seeing the problem go away there when I added the contents of this PR to my local beaker. Does this only come into effect when using the provision subcommand? Our jobs currently don't, but we could probably update them to do so if needed.

@mihaibuzgau
Copy link
Contributor Author

@Magisus that's correct, the packages will be installed by using beaker provision command.

@Magisus
Copy link
Contributor

Magisus commented Mar 11, 2020

Thanks, I'll look into adding that for our jobs!

Copy link
Contributor

@Magisus Magisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got our test run using beaker subcommands and confirmed this fixes our issue too.

@mattkirby mattkirby merged commit df834d6 into voxpupuli:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants