Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation error #3

Closed
ghost opened this issue Apr 26, 2021 · 3 comments
Closed

Translation error #3

ghost opened this issue Apr 26, 2021 · 3 comments
Assignees
Labels
bug Something isn't working fixed

Comments

@ghost
Copy link

ghost commented Apr 26, 2021

not sure if u know this but

Describe the bug
Selecting killstreak type after Professional bugs out, causes unknown translation error

To Reproduce
Steps to reproduce the behavior:

  1. Type !ks
  2. Select weapon
  3. Select type three times
  4. See error

Screenshots
image
probably caused by the slot + 1 from 8d2c07f

Unrelated error
image
happens after disconnect before apply i think, u need to add IsClientInGame check

also would u be able to port to TF2EconData and do an !item, !festivized, and !warpaint plugin and maybe add an admin command to choose for players such as sm_aussie_force, sm_ks_force, etc?

i would do a pull request for the errors but im lazy

thanks for the plugins!

@punteroo
Copy link
Owner

Hello, thank you for reporting this issue.

For now, I will just fix the problem regarding translations. Never heard of TF2EconData before, but by the looks of it I will make a port to that so I can finally ditch TF2IDB.

I will mark this for now and update you whenever a new release fixing this is issued. Thank you so much!

@punteroo punteroo added being worked on bug Something isn't working documentation Improvements or additions to documentation labels Apr 27, 2021
@punteroo
Copy link
Owner

punteroo commented May 3, 2021

Thank you for waiting.

I have issued a hotfix for this with this commit 9f15347
The new vip-killstreak plugin without this error is up. Thank you for reporting this issue, I will also take into account TF2EconData, whenever I get time to spare I'll port everything over.

I'll leave this issue open, until I do this porting.

@punteroo punteroo added fixed and removed being worked on documentation Improvements or additions to documentation labels May 3, 2021
@punteroo punteroo self-assigned this Oct 12, 2021
@punteroo
Copy link
Owner

Finally posting the final product. This has all been solved thanks to this issue, the port is now complete!

Release v3.0.0 is available here: https://github.com/punteroo/TF2-Item-Plugins/releases/tag/v3.0.0

Thank you for recommending TFEconData to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

1 participant