Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Positions for Specific Effects #2

Closed
LifeDreamer24 opened this issue Feb 28, 2021 · 4 comments
Closed

Wrong Positions for Specific Effects #2

LifeDreamer24 opened this issue Feb 28, 2021 · 4 comments
Assignees
Labels
bug Something isn't working fixed

Comments

@LifeDreamer24
Copy link

Bug Description
Some of the unusual effects aren't in the right place. Which are either attached too low, (on the neck / under the head) or even on the waist (rotating around the torso or so)...

To Reproduce
Steps to reproduce the behavior:

  1. Enter 'sm_unu' or any command to bring up the menu.
  2. Equip yourself a specific hat. (on my side i tried the 'Antarctic Eyewear' or the 'Bat Hat' which made the bug)
  3. Select the 'Circling TF Logo' if you have the 'Bat Hat' or the 'Divine Desire' if you equipped the 'Antarctic Eyewear'.
  4. See error

Additional Notes
Thoses bugs can sometimes happen with simillar effects e.g. 'Subatomic' or 'Atomic' for the neck bug but i did not found some effects that cause the bug related to the waist bug with the 'Circling TF Logo'.

Screenshots
bugreport1
bugreport2

Hope this can help/be useful.
/Simon ;)

@punteroo
Copy link
Owner

punteroo commented Mar 2, 2021

Hello, thank you for reporting this issue!

This happens because of certain hats' equip region. The engine just doesn't know which bone the effect must be attached to, so it does this. I'll try to implement a fix where players would be able to "adjust" their unusual effects' height just like if you were inside the loadout tab, and probably implement some sort of validation system to automatically re-attach the effect (will take quite some time to research).

I'll mark this issue and keep you updated on progress. If resolved, I'll push a new release.

@punteroo punteroo added being worked on bug Something isn't working labels Mar 2, 2021
@punteroo
Copy link
Owner

punteroo commented Mar 2, 2021

Performed some tests on my real Unusual hat and attributes that control the effects' position are particle_effect_use_head_origin and particle_effect_vertical_offset (IDs 520 and 519 respectively).

I'll try to implement these on the Unusuals plugin for a dynamic fix.

@punteroo punteroo self-assigned this Mar 2, 2021
@punteroo
Copy link
Owner

punteroo commented Mar 2, 2021

Confirmed to be malfunctioning with The Bat Hat

Wrong Position

@punteroo
Copy link
Owner

punteroo commented Mar 4, 2021

This has been fixed on the latest v2.3.2 release.

Thanks for reporting this issue! I'll close it now.

@punteroo punteroo closed this as completed Mar 4, 2021
Repository owner locked as resolved and limited conversation to collaborators Mar 6, 2021
@punteroo punteroo added the fixed label Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

2 participants