Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce in CI that checked in examples schemas are accurate #294

Open
iwahbe opened this issue Feb 14, 2025 · 0 comments
Open

Enforce in CI that checked in examples schemas are accurate #294

iwahbe opened this issue Feb 14, 2025 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@iwahbe
Copy link
Member

iwahbe commented Feb 14, 2025

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

#293 showed that CI doesn't require that generating schemas doesn't show changes. We should enforce that in CI.

Post-#293, we can do this by asserting that git diff shows no changes after running make test_examples.

Affected area/feature
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team labels Feb 14, 2025
@rquitales rquitales removed the needs-triage Needs attention from the triage team label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iwahbe @rquitales