DiffConfig causes a replacement when a default provider is upgraded

[rquitales]

What happened?

This was identified in pulumi/pulumi-docker-build#404 where a Pulumi program using a default provider undergoes a replacement whenever the Pulumi program upgrades its provider version used.

The root cause identified is that an __internal field is added to inputs, but removed once we store the outputs in state. This library currently diffs against new inputs, and old state. This means that a replacement will always occur if the default provider is used and updated since __internal is always present in new inputs, but stripped in the old state.

We should either provide a way to have consumers of this library be able to customize this behavior, and pick what objects to diff against, or to only diff against inputs (which is what bridged providers do).

Example

pulumi/pulumi-docker-build#404

Output of pulumi about

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).