Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of date examples #928

Closed
t0yv0 opened this issue Oct 18, 2023 · 4 comments
Closed

Out of date examples #928

t0yv0 opened this issue Oct 18, 2023 · 4 comments
Assignees
@thomas11
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 18, 2023

What happened?

Looks like some examples reference ancient versions of dependencies that no longer work standalone. They work in CI by substituting in ambient provider build.

Example

cd examples/cluster-go && pulumi preview

will fail

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@t0yv0 t0yv0 added needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec labels Oct 18, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 19, 2023

Looks like this might be solved already in #910 - excellent.

@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Oct 19, 2023
@thomas11 thomas11 added the resolution/fixed This issue was fixed label Nov 13, 2023
@thomas11
Copy link
Contributor

Fixed by #910.

@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have an assignee

Please fix these problems and try again.

@pulumi-bot pulumi-bot reopened this Nov 13, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 13, 2023

Whoops this did not close because no assignee. Assigning you Thomas, thanks a ton!

@t0yv0 t0yv0 closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas11 thomas11

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thomas11 @t0yv0 @pulumi-bot