Clean up end-to-end tests #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an obsolete test (managed-ng-os-py), it was added before nodejs and the rest of the SDKs shared the same implementation. This functionality is now covered by the nodejs test (managed-ng-os). Additionally it changes the tests e2e tests to place instances in private subnets in order to reduce the EIP usage.
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
commented
Dec 23, 2024
| scalingConfig: { | ||
| minSize: 1, | ||
| maxSize: 1, | ||
| desiredSize: 1, | ||
| }, | ||
| subnetIds: eksVpc.privateSubnetIds, |
There was a problem hiding this comment.
This one alone should free up 14 EIPs...
t0yv0
approved these changes
Dec 23, 2024
|
This PR has been shipped in release v3.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an obsolete test (managed-ng-os-py), it was added before nodejs and the rest of the SDKs shared the same implementation. This functionality is already covered by the nodejs based test (managed-ng-os).
Additionally it changes the e2e tests to place instances in private subnets in order to reduce the EIP usage (reduces contention and saves money).