Autonaming of SNS fifo topics

[woeps]

The name of a SNS fifo topic has to end with .fifo. Currently, a hash is appended to the topic name provided via args. (no matter if fifo or not) Trying to create a fifo topic yields the error invalid topic name.

The code example of the Pulumi SNS docs demonstrate this exact erroneous behaviour.

related issue

The same kind of issue has already been reported and resolved for SQS fifo queues (#967). The provider's autonaming implementation for SQS fifo queues calculates names like this: <name>-<hash>.fifo, if fifo argument is true.
Whereas a SNS fifo topic's name is not handled differently than a regular SNS topic in the implementation.

possible workarounds

• overwrite the resource name via opts (could result in other issues - especially if trying to deploy the same code multiple times to different environments or similar)
• use stack transformation to rename all topics accordingly

Steps to reproduce

1. create a SNS fifo topic: code taken from the Pulumi SNS docs:

import * as pulumi from "@pulumi/pulumi";
import * as aws from "@pulumi/aws";

const userUpdates = new aws.sns.Topic("user_updates", {
    contentBasedDeduplication: true,
    fifoTopic: true,
});

2. deploy Pulumi application

Expected:
SNS fifo topic created, named user_updates-<hash>.fifo

Actual:
SNS fifo topic created, named user_updates-<hash> - note the missing fifo