Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync-and-test-bucket script fails unless bundles bucket exists #10113

Closed
cnunciato opened this issue Oct 22, 2023 · 3 comments
Closed

sync-and-test-bucket script fails unless bundles bucket exists #10113

cnunciato opened this issue Oct 22, 2023 · 3 comments
Assignees
@cnunciato
Labels
docs-ops kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone
0.96

Comments

@cnunciato
Copy link
Contributor

cnunciato commented Oct 22, 2023 •
edited
Loading

The push workflow runs sync-and-test-bucket.sh update, which relies on the existence of a "bundles" bucket -- but this bucket is created and exported by the Pulumi program, which runs after the script:

https://github.com/cnunciato/docs/blob/dadda3729ff3ca98d720e7cac6cf5b5b07f2e655/scripts/sync-and-test-bucket.sh#L72

This means pulumi up on a new stack can never succeed. We should fix this.
@cnunciato cnunciato changed the title sync-and-test-bucket script fails unless bundles bucket exists first`` sync-and-test-bucket script fails unless bundles bucket exists Oct 22, 2023
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Oct 22, 2023
@github-project-automation github-project-automation bot moved this to 🤔 Triage in Docs 📚 Oct 22, 2023
@cnunciato
Copy link
Contributor Author

@sean1588 Do we actually need this bucket? I'm not sure we do, since we're building everything separately now.

@toriancrane toriancrane added kind/bug Some behavior is incorrect or out of spec docs-ops and removed needs-triage Needs attention from the triage team labels Oct 25, 2023
@toriancrane toriancrane moved this from 🤔 Triage to 🎬 Ready in Docs 📚 Oct 25, 2023
@sean1588
Copy link
Member

We do still need it for now with the way things are configured. We would need to find a way to host the registry assets somewhere under the /registry route and not under the root (where the bundles bucket is accessed from under /registry) in order for the registry pages to resolve the location of those files.

@cnunciato cnunciato added the resolution/fixed This issue was fixed label Oct 27, 2023
@cnunciato cnunciato self-assigned this Oct 27, 2023
@cnunciato cnunciato added this to the 0.96 milestone Oct 27, 2023
@cnunciato cnunciato added the size/S Estimated effort to complete (1-2 days). label Oct 27, 2023
@cnunciato
Copy link
Contributor Author

Fixed via #10137.

@github-project-automation github-project-automation bot moved this from 🎬 Ready to 🏁 Done in Docs 📚 Oct 27, 2023
@interurban interurban removed the status in Docs 📚 Dec 5, 2023
@interurban interurban moved this to 🏁 Done in Docs 📚 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnunciato cnunciato

Labels
docs-ops kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
Docs 📚
Archived in project
Milestone
0.96
Development

No branches or pull requests
3 participants
@cnunciato @sean1588 @toriancrane