Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page Action #32

Open
Tracked by #1
trickypr opened this issue Dec 11, 2023 · 2 comments
Open
Tracked by #1

Page Action #32

trickypr opened this issue Dec 11, 2023 · 2 comments
Labels
c/webext Anything catagorized as webextensions tracking An issue created by @trickypr for a planned feature
Milestone
MVB

Comments

@trickypr
Copy link
Member

No description provided.

@trickypr trickypr mentioned this issue Dec 11, 2023
Open
23 tasks
@trickypr trickypr added tracking An issue created by @trickypr for a planned feature c/webext Anything catagorized as webextensions labels Dec 11, 2023
@trickypr trickypr added this to the MVB milestone Dec 11, 2023
@trickypr trickypr linked a pull request Dec 24, 2023 that will close this issue
🚧 Partial implementation of the pageAction api #41
Merged
@trickypr trickypr removed a link to a pull request Dec 24, 2023
🚧 Partial implementation of the pageAction api #41
Merged
@trickypr
Copy link
Member Author

As per #41, the following need to be implemented:

  • isShown
  • setTitle and getTitle
  • setIcon
  • setPopup and getPopup
  • openPopup

@trickypr
Copy link
Member Author

After #60, EPageAction and the renderer should be rewritten to reduce code duplication. The other solution is a lot cleaner and simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/webext Anything catagorized as webextensions tracking An issue created by @trickypr for a planned feature
Projects
None yet
Milestone
MVB
Development

No branches or pull requests
1 participant
@trickypr