Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Handling of Invalid Slave Address Requests #83

Open
mubashir913 opened this issue Nov 21, 2024 · 2 comments
Open

Incorrect Handling of Invalid Slave Address Requests #83

mubashir913 opened this issue Nov 21, 2024 · 2 comments

Comments

@mubashir913
Copy link

mubashir913 commented Nov 21, 2024

I have generated a NoC using FlooNoC and encountered an issue during testing. When an AXI Master driver sends a request to a slave address that is not defined in the Slave Address Map (SAM), the NoC consistently forwards the request to a specific slave.

While the DECODE error assertion is correctly shown on the terminal, the response returned to the master has RESP = 0, because it is coming from a slave driver rather than being handled as an invalid address case.

Shouldn't the NoC handle such requests by not forwarding them to any slave and instead directly sending a response back to the master with RESP = 3 (DECERR), as per the AXI4 protocol?

P.S. In the floo_route_comp module, the en_default_idx_i and default_idx_i signals of addr_decode module are set to 0.

@mubashir913 mubashir913 changed the title Incorrect Handling of Invalid Slave Address Requests in FlooNoC Incorrect Handling of Invalid Slave Address Requests Nov 21, 2024
@fischeti
Copy link
Collaborator

Yes, this would be the better way to handle it indeed. #79 addresses this problem by inserting AXI error slaves in the network interfaces. But that PR is not yet ready to be merged.

@mubashir913
Copy link
Author

Okay thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants