Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New LuxFooter component Light Theme needs different colors #300

Open
3 tasks
sdellis opened this issue Jul 31, 2024 · 0 comments
Open
3 tasks

New LuxFooter component Light Theme needs different colors #300

sdellis opened this issue Jul 31, 2024 · 0 comments
Assignees

Comments

@sdellis
Copy link
Member

sdellis commented Jul 31, 2024

Current display

The current <lux-footer theme='light' /> variation has a white background. This looks strange on pages that already have a white background because it doesn't differentiate the footer from the rest of the page. There is also text that is invisible to the eye because it's white-on-white.

Screenshot 2024-07-31 at 1 24 15 PM

Desired display

The light theme should have an off-white background var(--color-grayscale-warm-lighter) and the text should be var(--color-rich-black). This is a screen shot of the old color scheme for reference.

Screenshot 2024-07-31 at 1 34 50 PM

Acceptance criteria

  • I can successfully use this feature with Voice Over in Safari.
  • I have checked this feature using one of the following browser extensions and confirmed that it does not add any level A or level AA issues:
    • axe dev tools
    • Lighthouse
    • Wave
  • ...

Notes

This is currently an Accessibility issue as well since there is no contrast between the background and some text.

@sdellis sdellis self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant