Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable publish button #728

Closed
james-tyner opened this issue Aug 2, 2024 · 1 comment · Fixed by #735
Closed

Add option to disable publish button #728

james-tyner opened this issue Aug 2, 2024 · 1 comment · Fixed by #735
Assignees
Labels
[severity][p1] High severity, needing quick resolution but not as urgent as P0 unconfirmed bug

Comments

@james-tyner
Copy link

Expected Behavior

In version 2.8.0 of PublishPress Checklists Pro, users are not allowed to click "Publish" on a post if required checklist tasks are not completed. Once they arrive at the "pre-publish checks" screen, the Publish button is grayed out until all checklist requirements are met.

Current Behavior

In version 2.12.0 of PublishPress Checklists Pro, nothing prevents users from clicking Publish, even if the checklist is not fulfilled. Instead, after clicking, the story fails to publish and users are shown a red error banner saying required checklist items must be completed before publishing.

Possible Solution

Restore disabled Publish button behavior, or at least make it an option in the plugin settings.

Context

I understand that some changes were made related to #567 to reduce conflicts with other plugins, and I'm guessing that's what led to the removal of interactions between PublishPress Checklists and the Publish button. But is there really nothing that can be done to maintain the old behavior? It was an elegant way to signal to users that there were pending tasks they needed to complete. The new behavior may lead to confusion among users who believe their story has published and don't notice the error message.

Your Environment

  • Version used: WordPress 6.6.1
  • Browser Name and version: Chrome 127
  • Operating System and version (desktop or mobile): macOS 14.6
@stevejburge
Copy link
Member

Hi @james-tyner. Thanks for using Checklists Pro. Can you open a support ticket? We'll dig into this for you

@stevejburge stevejburge added this to the 2.13: ACF Integration milestone Aug 3, 2024
@richaferry richaferry added the [severity][p1] High severity, needing quick resolution but not as urgent as P0 label Aug 5, 2024
@rizaardiyanto1412 rizaardiyanto1412 changed the title Publishing is no longer blocked by incomplete checklist items Add option to disable publish button Aug 6, 2024
@rizaardiyanto1412 rizaardiyanto1412 linked a pull request Aug 6, 2024 that will close this issue
6 tasks
@richaferry richaferry mentioned this issue Aug 28, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[severity][p1] High severity, needing quick resolution but not as urgent as P0 unconfirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants