-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Notification When User Likes Research Note #9353
Comments
Can I work on this one? |
@jcads Yeah, go for it! Post a comment here if you need any pointers, or if you need some help. :) |
This comment has been minimized.
This comment has been minimized.
oh, sorry this is not a first-timer issue... my bad @jcads sorry for the confusion... |
As there is no update on this, can I take up this issue? |
@sahilsaha7773 I am assuming that @jcads is working on it, they'll let you know if they stop working on it. |
okay sure, thanks! |
Yes I am still working on this. Will open a PR in a couple of days, I just have to finish some internship stuff. |
@noi5e here's what I came up with: What do you think? |
Description
Let's display a notyNotification when a user likes a research note. And also a second notification when the user dislikes a research note.
See this thread for more context.
Why Do This?
Here's a video of what happens when a user likes a research note:
Screen.Recording.2021-03-22.at.12.44.22.PM.mov
For example, here's the notification that we use when a user posts a comment (in the top-right corner):
Screen.Recording.2021-03-22.at.12.50.41.PM.mov
How to Implement
The comment example above is done here in
create.js.erb
:plots2/app/views/comments/create.js.erb
Line 42 in 07a243d
We can add similar notyNotifications here in
like.js
, depending on if the research note is liked or disliked:plots2/app/assets/javascripts/like.js
Lines 14 to 25 in 07a243d
The text was updated successfully, but these errors were encountered: