camelCase JavaScript Asset Filenames

[noi5e]

See this comment thread.

Some of the JS assets use camelCase naming convention, while others use underscore_filename convention:

Let's standardize them and use camelCase since that's the JS way! These make great first-timer-only issues. (I definitely welcome help in making these!)

Don't forget to do a search in your IDE for wherever the file is required. For example, some of these are loaded in config/initializers/assets.rb.

Completed

• advanced_search.js
  • 🔍 [open issue camelCase advanced_search.js filename #9141]
  • 🙋 [claimed by @Hari-tn67]
  • ❗ [PR camelCase advanced_search.js filename #9163]
  • 🎉 [merged on 2/10!]
• async_tag_subscriptions.js
  • 🔍 [open issue camelCase async_tag_subscriptions.js filename #9142]
  • 🙋 [claimed by @katiebankhead on 2/13]
  • ❗ [PR Rename async_tag_subscriptions.js to asyncTagSubscriptions.js #9194]
  • 🎉 [merged on 2/14!]
• atwho_autocomplete.js
  • 🔍 [open issue camelCase atwho_autocomplete.js filename #9143]
  • 🙋 [claimed by @shadowoflight on 2/13]
  • ❗ [PR camelCase atwho_autocomplete.js filename #9192]
  • 🎉 [merged on 2/15!]
• comment_expand.js
  • 🔍 [open issue camelCase comment_expand.js filename #9144]
  • 🙋 [claimed by @manchere on 2/16]
  • ❗ [open PR Fix comment_expand to camelcase #9206]
  • 🎉 [merged on 2/16!]
• header_footer.js
  • 🔍 [open issue camelCase header_footer.js filename #9146]
  • 🙋 [claimed by @StellaWanja on 2/7]
  • ❗ [PR Changes to the header_footer.js filename #9156]
  • 🎉 [merged on 2/9!]
• leaflet_helper.js
  • 🔍 [open issue camelCase leaflet_helper.js filename #9147]
  • 🙋 [claimed by @redwan-mahmud on 2/11]
  • ❗ [PR camelCase leaflet_helper.js filename #9147]
  • 🎉 [merged on 2/15!]
• main_image.js
  • 🔍 [open issue camelCase main_image.js filename #9148]
  • 🙋 [claimed by @larabee7777 on 2/11]
  • ❗ [open PR Rename main_image.js to mainImage.js #9201]
  • 🎉 [merged on 2/16!]
• noty_notification.js
  • 🔍 [open issue camelCase noty_notification.js filename #9149]
  • 🙋 [claimed by @akshay4n on 2/21]
  • ❗ [PR Akshay4n patch 1 #9223]
  • 🎉 [ready to merge!]
• restful_typeahead.js
  • 🔍 [open issue camelCase restful_typeahead.js filename #9150]
  • 🙋 [claimed by @ghostoverflow on 2/21]
  • ❗ [PR Rename restful typeahead #9228]
  • 🎉 [merged on 2/23!]
• submit_form_ajax.js
  • 🔍 [open issue camelCase submit_form_ajax.js filename #9151]
  • 🙋 [claimed by @StreakSharn on 2/7]
  • ❗ [PR camelCase - submitFormAjax.js #9157]
  • 🎉 [merged on 2/9!]
• textbox_expand.js
  • 🔍 [open issue camelCase textbox_expand.js filename #9152]
  • 🙋 [claimed by @Nagsenwaghmare on 2/8]
  • ❗ [PR camelCase textbox_expand.js filename #9153]
  • 🎉 [merged on 2/9!]

🔬 Needs Further Research

• simple-data-grapher.js
  • This seems to be one of Public Lab's own external packages that we require in package.json?
  • May not be so easy to change this one, or out-of-scope for an FTO.

[larabee7777]

Hi do you need help here?

[noi5e]

@larabee7777 You've already completed one of these first-timer-only issues (#9148). I think generally each person gets only one FTO issue.

If you're looking for another way to contribute, you could browse through our help wanted issues. OR you could also help someone else get through their own FTO issue. maybe the two open issues above? You could leave a comment there seeing if they need any help.

You can also make your own FTO issue. We have a bunch of first-timer-only candidate issues that need to be broken down and formatted into FTO issues.

[larabee7777]

@larabee7777 You've already completed one of these first-timer-only issues (#9148). I think generally each person gets only one FTO issue.

If you're looking for another way to contribute, you could browse through our help wanted issues. OR you could also help someone else get through their own FTO issue. maybe the two open issues above? You could leave a comment there seeing if they need any help.

You can also make your own FTO issue. We have a bunch of first-timer-only candidate issues that need to be broken down and formatted into FTO issues.

Ah ok I see thanks so much I will check out the other issues :)

[noi5e]

Okay, I think with the two PRs that got merged today, we can close this issue!!! Thanks to everyone who made their first PRs and helped us with this! @Hari-tn67 @katiebankhead @shadowoflight @manchere @StellaWanja @redwan-mahmud @larabee7777 @akshay4n @ghostoverflow @StreakSharn @Nagsenwaghmare 🏆 🎉 🍾

If any of you would like to help out some more, or get more experience in open source, check out https://code.publiclab.org/. Feel free to check out our help wanted issues, create your own first-timer-only issue, do code review... You can also ask for help setting up plots2 locally, try to find bugs, or write issues. And if you haven't checked us out on Gitter, please do!