Bullet gem in development mode

[Tlazypanda]

Please describe the desired behavior.
Given the performance issues we have been facing lately, was thinking of adding Bullet gem in the development mode and necessary config. We can then add some documentation to suggest contributors to check their added queries and whether they are performant or not before opening a pull request. There is also a possibility of adding bullet in tests but will have to check out how it exactly works.

Bullet gem will flag issues such as N+1, unnecessary eager loading etc. through log/bullet.log file, browser console and as a js alert on the page.
https://github.com/flyerhzm/bullet

[Tlazypanda]

Hey Jeff! What do you think about this @jywarren? Let me know ✌️

[anirudhprabhakaran3]

This is a pretty good suggestion! My college uses rails for our UIMS, and bullet has helped a lot in dev, especially for N+1 queries. I definitely think this should be there

[jywarren]

This looks really nice! How would such issues be presented/displayed, like what would be an example, and how might we encourage people to read them and generate issues from them? Could we have a "support" issue for combing through these?

support

Also, would it block anything? I guess if it's integrated into tests, it might, but not otherwise?

[anirudhprabhakaran3]

So, as far as I understand, bullet doesn't play any part in tests. it's used just during the development cycle, and not in tests.
Bullet doesn't prevent any bad queries from being added to the code, it'll just alert the developer to the inefficient queries. Whether we want to correct them or not is up to us.

Bullet actually displays errors as a pop-up JS alert when the page with inefficient queries is loaded. Along with that, there is a more descriptive hovering footer kind of section, that displays which query is causing the error, and if there are any quick fixes to it. Usually, the fixes that are specified are good enough.

People coming across these errors can make issues and FTOs from it. It'll help make the code cleaner, and also help drive community involvement!

[starswan]

Bullet can be set into 'raise exceptions' mode where tests will fail on N+1 issues. It can be very difficult to make all the scenarios pass though - and sometimes you have to accept occasional over-eager loads depending on what the view ends up doing