Total Tag count on tag stats pages seems incorrect for tag "beach"

[jywarren]

Reporting in here from @ebarry and Jeanette, the graph at https://publiclab.org/tag/beach/stats seems correct, but below it the "Total Tag count" of 8 seems wrong, by their count.

That code is driven from here:

plots2/app/views/tag/_graph.html.erb

Lines 4 to 8 in c60aaab

	<% if @tags.first.count.nil? %>
	<i> There are no posts for this tag yet </i>
	<% else %>
	<b>Total Tag count : <%= @tags.first.count %></b>
	<% end %>

Strange -- @tags.first.count would seem to be running Tag.where(name: params[:id]).first.count, which doesn't make sense to me.

Looking deeper, cc @cesswairimu as well...

[jywarren]

Aha - more sense here: it's not doing a database count, it's accessing an attribute named count on the Tag model:

irb(main):036:0> Tag.where(name: 'beach').first.count
=> 8
irb(main):037:0> Tag.where(name: 'beach').first
=> #<Tag tid: 15452, vid: 3, name: "beach", description: "", weight: 0, count: 8, parent: nil>

[jywarren]

So, perhaps that's simply not getting updated. Let's see where else we count tag usage, and also where we update the attribute...

[jywarren]

Looks like we need to be running this to maintain that attribute:

plots2/app/models/tag.rb

Lines 39 to 42 in d9e7f11

	def run_count
	self.count = NodeTag.where(tid: tid).count
	save
	end

We do that each time a tag is added:

plots2/app/models/node.rb

Line 845 in 122e8a7

tag.run_count # update count of tag usage

OK, so when run_count is run, we get 8 for beach

However, when we run this, we see there are only 4 notes (and no wikis) for beach:

Tag.find_nodes_by_type('beach', 'note').count

[jywarren]

Aha - so 4 are attached to nodes that are not status = 1:

irb(main):053:0> NodeTag.joins(:node).where(tid: 15452).where('node.status = 1').count
=> 4
irb(main):055:0> NodeTag.joins(:node).where(tid: 15452).where('node.status != 1').count
=> 4

Great, there's our discrepancy!

[jywarren]

OK wait we have to run run_count on all tags!!! https://stable.publiclab.org/tag/beach/stats

[jywarren]

So we'll need to run:

Tag.all.each do |tag|
  tag.run_count
end

[cesswairimu]

Great detective work 🎉

[jywarren]

Running this on stable.publiclab.org now to test.

[ebarry]

Exciting to see this detective work yield results!

[jywarren]

Sorry, this was completed long ago and is live! Closing!