Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very few suggestions show up for subscription #7289

Closed
imajit opened this issue Jan 18, 2020 · 2 comments · Fixed by #7338
Closed

Very few suggestions show up for subscription #7289

imajit opened this issue Jan 18, 2020 · 2 comments · Fixed by #7338
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed

Comments

@imajit
Copy link
Contributor

imajit commented Jan 18, 2020

On this page link when I try to add new tags to subscribe to then very few suggestions show up in the drop down like balloon mapping, spectrometer and thermal flashlight .
Screenshot from 2020-01-18 16-27-00
In this field
bug

What I was expecting was to find all tags orders in some manner to appear when I type a letter like if I type 'a' then all the tags with 'a' in it should appear which doesn't seem to happen .

@imajit imajit added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label Jan 18, 2020
@welcome
Copy link

welcome bot commented Jan 18, 2020

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@nstjean
Copy link
Contributor

nstjean commented Jan 23, 2020

So it looks like that was the idea, eventually, but that it was never coded in so it's just some "example tags" hardcoded in.

I'm looking through https://github.com/publiclab/plots2/blob/master/app/models/tag.rb which is the model for Tag. I don't see any functions that get all tags from the database. What you'd need to do is add a function like all_tags_by_popularity and in it you'd use ActiveQuery to get all unique tagnames from the database, sorted by how frequently it has been used. This could be pretty challenging to accomplish! You'd also have to filter out any powertags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants