Fix pluralization logic IV

[sashadev-sky]

Please note we are preparing to participate in Google Code-in, and have reserved this issue for GCI participants - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

The problem

On the /notes/author/admin page, the pluralization for research notes is incorrect:

Solution

When plugging in values that are subject to change, we need to make sure the text it'll generate is appropriate for both the singular and plural case.

-- lets find the relevant line of code first:

the text is generated here:

plots2/app/views/notes/index.html.erb

Line 14 in a5d3392

<h3><%= raw t('notes.index.research_by', :url1 => "/people/"+@user.name, :user_name => @user.name) %> <small><%= raw t('notes.index.research_notes_and_wiki_edits', :count1 => @user.note_count, :count2 => @user.revisions.count) %> <% if @user.notes.length > 0 %><%= raw t('notes.index.starting_time', :time => time_ago_in_words(@user.created_at)) %><% end %></small></h3>

with additional help from here:

plots2/config/locales/en.yml

Lines 158 to 159 in b3dc712

	research_notes_and_wiki_edits: "%{count1} research notes and %{count2} wiki
	edits"

There are many ways to fix this

• I like this solution - "you can make use of the pluralization features of the I18n library by defining count values to translation keys". http://stackoverflow.com/questions/25064677/ddg#25065514
• But do it however! Just make sure your solution is DRY, as in sticks to using the locale helpers if this variable is used frequently throughout the repo, or a rails/ruby/etc. method that helps to handle this logic. No if count == 1 ... else .... here please as we have both "note(s)" and "edit(s)" to consider.

Requirements:

• DRY
• accounts for both "note(s)" and "edit(s)"

Thanks!!

Step by Step

• Claim this issue with a comment here, below, and ask any clarifying questions you need
• Fork the repository and set it up locally following the main repo README instructions https://github.com/publiclab/plots2
• Create a new feature branch with a unique name descriptive to the issue
• Try to fix the issue following the steps above, but even before you're done, you can:
  commit your changes to your branch and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
• Reference this issue in your pull request body
• Once you submit your pull request, an additional checklist will be provided for getting it merged

💬 Get help

If you need any help - here are some options:

• Comment below
• Join our gitter chat at https://gitter.im/publiclab/publiclab

[sashadev-sky]

Uploaded to GCI Dashboard

[SidharthBansal]

PUBLISHED