Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow button not showing the user is subscribed on the /subscriptions page #5485

Closed
Souravirus opened this issue Apr 15, 2019 · 13 comments
Closed
Labels
help wanted requires help by anyone willing to contribute JavaScript

Comments

@Souravirus
Copy link
Member

Reported on #5182
The subscribe button is actually working in the backend but it's not being shown to the user. Also, the user count is not increased after clicking the follow button.

The page is this and here is the screenshot.
image

@Souravirus Souravirus added help wanted requires help by anyone willing to contribute JavaScript labels Apr 15, 2019
@divyabaid16
Copy link
Contributor

If this issue is open to be worked upon, I would like to give it a try. Thanks!

@gautamig54
Copy link
Contributor

gautamig54 commented Apr 15, 2019

The user count is increased on refreshing the page. Also, we can add a toggle button for following or unfollowing a tag in the same subscription column. Currently, the "follow" button also changes to "following" when the page is refreshed.

@gautamig54
Copy link
Contributor

gautamig54 commented Apr 15, 2019

@divyabaid16 Can we divide the issue?
I can create a toggle button for following or unfollowing a tag and you can work upon the incrementing the user count without needing to refresh the tags page.

@divyabaid16
Copy link
Contributor

Sure!!

@gautamig54
Copy link
Contributor

Should the user be allowed to delete their subscription from the tags page directly?
There is a separate page for managing subscriptions which provides the user an option to unsubscribe a particular tag.
Considering this, If a user follows a certain tags and wishes to unfollow it, we can direct the user directly to the "Manage Subscriptions" page rather than the tag specific page.
What do you think @Souravirus @divyabaid16 ?

@Souravirus Souravirus changed the title Subscribe button not showing the user is subscribed on the tag page Follow button not showing the user is subscribed on the tag page Apr 16, 2019
@Souravirus
Copy link
Member Author

Yeah that would also be great. Thank you for working on it.

@gautamig54
Copy link
Contributor

I have written a code for changing the text from "follow" to "following" when clicked. But, it only works once. I will have to refresh the page again for the click to work again. It can be because the query is set to work only for one action. What do you think about this @divyabaid16?

@divyabaid16
Copy link
Contributor

@gautamig54 I guess you will need to make changes in routes.rb
Also, I would like to give one more suggestions, if we could auto refresh the page during certain interval of time like suppose 5 mins so that all the update in the page can be visible and there will be no need to refresh the page in certain inrerval.

@divyabaid16
Copy link
Contributor

Should the user be allowed to delete their subscription from the tags page directly?
There is a separate page for managing subscriptions which provides the user an option to unsubscribe a particular tag.
Considering this, If a user follows a certain tags and wishes to unfollow it, we can direct the user directly to the "Manage Subscriptions" page rather than the tag specific page.
What do you think @Souravirus @divyabaid16 ?

@gautamig54 Regarding this, a new layout of tags page was proposed by @jywarren in issue #5090
In this, the user can unsubscribe directly.

@Utiwari1999
Copy link

@Souravirus I want to work on this issue.

@jainil-4801
Copy link

@Souravirus I also want to work on this issue.

@jywarren jywarren changed the title Follow button not showing the user is subscribed on the tag page Follow button not showing the user is subscribed on the /subscriptions page Nov 20, 2019
@jywarren jywarren added this to the Tagging and topics milestone Nov 20, 2019
@Souravirus
Copy link
Member Author

Hi @Utiwari1999, sorry for the late reply. Yeah you can surely work on this. Thank you!!

@jywarren
Copy link
Member

jywarren commented Jan 3, 2020

I believe this is resolved in the new design, thank you!!!

@jywarren jywarren closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted requires help by anyone willing to contribute JavaScript
Projects
None yet
Development

No branches or pull requests

6 participants