Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running bower twice for testing #3261

Open
icarito opened this issue Aug 25, 2018 · 2 comments
Open

Avoid running bower twice for testing #3261

icarito opened this issue Aug 25, 2018 · 2 comments

Comments

@icarito
Copy link
Member

icarito commented Aug 25, 2018

https://gitlab.com/publiclab/plots2/commit/2292036555b77f901256387eaa15e436874a538a

I tried the above patch but it somehow broke Jenkins. We should try again.
Bower is configured (thru ./.bowerrc) to put libs in ./public/lib but then we also mount the current dir, so we shadow the files with the current directory. That's why we've needed to run bower twice, but we will save some time if we manage to solve this! Maybe putting bower libs outside /app?

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

https://publiclab.org/ ...

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@jywarren
Copy link
Member

We moved the bower files into a public folder because they include some CSS and JS files we needed to be able to link to directly without compiling them in with Sprockets. It has ended up being useful also for checking the installed version of a library directly via a URL... like https://publiclab.org/lib/jquery/dist/jquery.js -- but if we can figure out the key issue above (see examples re: Leaflet and Woofmark here: https://github.com/publiclab/plots2/search?q=lib%2F&unscoped_q=lib%2F) we could do this, yeah!

@icarito
Copy link
Member Author

icarito commented Sep 8, 2018

Here I've tried again with the exact same commit and it worked in Jenkins too. Merging https://github.com/publiclab/plots2/pull/3306/files should work and not affect production!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants