Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #4076 : remove drupal file and drupal upload #11475

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

toshitapandey
Copy link
Contributor

@toshitapandey toshitapandey commented Oct 13, 2022

Fixes #4076

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Purpose

  • Remove drupal_file model
  • Remove drupal_upload model
  • Remove association from drupal_main_image model
  • Update .rubocop_todo.yml to not include removed models
  • Remove association from node model
  • Drop files table
  • Drop upload table
  • Update db/schema.rb.example to not have upload and files tables

@toshitapandey toshitapandey requested a review from a team as a code owner October 13, 2022 13:33
@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2022

@toshitapandey toshitapandey requested a review from a team as a code owner October 13, 2022 13:44
@codeclimate
Copy link

codeclimate bot commented Oct 13, 2022

Code Climate has analyzed commit 4e1f8d6 and detected 0 issues on this pull request.

View more on Code Climate.

@toshitapandey
Copy link
Contributor Author

@jywarren @TildaDares - When I remove upload and files tables, the build is failing. Do you have any idea why this might be happening?

@anirudhprabhakaran3
Copy link
Member

Hi! So the tests are probably failing because there are dependencies in the test files. Try running the test suite, and see what errors are logged.

For more detailed analysis, you can run every test file and see what the failures are. If you need any help, feel free to send a message here, pinging me.

@stale
Copy link

stale bot commented Oct 15, 2023

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate DrupalFile and DrupalUpload tables and remove associated code to simplify codebase
2 participants